Skip to content

cmd/cgo: perform explicit conversion in _GoStringLen #27092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danieldk wants to merge 1 commit into from
Closed

cmd/cgo: perform explicit conversion in _GoStringLen #27092

danieldk wants to merge 1 commit into from

Conversation

@danieldk
Copy link
Contributor

@danieldk danieldk commented Aug 20, 2018 •
edited
Loading

_GoStringLen performs an implicit conversion from intgo to size_t.
Explicitly cast to size_t.

This change avoids warnings when using cgo with CFLAGS:
-Wconversion.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Aug 20, 2018
@gopherbot
Copy link
Contributor

gopherbot commented Aug 20, 2018

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/129820.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Aug 20, 2018

Message from Gerrit User 5065:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/129820.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Aug 20, 2018

Message from Gerrit User 5976:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=8741dd47

Please don’t reply on this GitHub thread. Visit golang.org/cl/129820.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Aug 20, 2018

Message from Gerrit User 5976:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/129820.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Aug 21, 2018

Message from Gerrit User 5206:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/129820.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Aug 21, 2018

Message from Gerrit User 5206:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/129820.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Aug 21, 2018

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/129820.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Aug 21, 2018

Message from Gerrit User 12446:

Uploaded patch set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/129820.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Aug 21, 2018

Message from Gerrit User 12446:

Uploaded patch set 4: New patch set was added with same tree, parent, and commit message as Patch Set 3.

Please don’t reply on this GitHub thread. Visit golang.org/cl/129820.
After addressing review feedback, remember to publish your drafts!

@danieldk
cmd/cgo: perform explicit conversion in _GoStringLen
b5df1ac 
_GoStringLen performs an implicit conversion from intgo to
size_t. Explicitly cast to size_t.
@gopherbot
Copy link
Contributor

gopherbot commented Aug 21, 2018

Message from Gerrit User 12446:

Uploaded patch set 6: New patch set was added with same tree, parent, and commit message as Patch Set 5.

Please don’t reply on this GitHub thread. Visit golang.org/cl/129820.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Aug 21, 2018

Message from Gerrit User 5206:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/129820.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Aug 21, 2018

Message from Gerrit User 5976:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=99f1c348

Please don’t reply on this GitHub thread. Visit golang.org/cl/129820.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Aug 21, 2018

Message from Gerrit User 5976:

Patch Set 6: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/129820.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Aug 22, 2018

Message from Gerrit User 5206:

Patch Set 6: Code-Review+2

Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/129820.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Aug 22, 2018
@danieldk @ianlancetaylor
cmd/cgo: perform explicit conversion in _GoStringLen
d2ace0c 
_GoStringLen performs an implicit conversion from intgo to size_t.
Explicitly cast to size_t.

This change avoids warnings when using cgo with CFLAGS:
-Wconversion.

Change-Id: I58f75a35e17f669a67f9805061c041b03eddbb5c
GitHub-Last-Rev: b5df1ac
GitHub-Pull-Request: #27092
Reviewed-on: https://go-review.googlesource.com/129820
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link
Contributor

gopherbot commented Aug 22, 2018

This PR is being closed because golang.org/cl/129820 has been merged.

@gopherbot gopherbot closed this Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danieldk @gopherbot @googlebot